elegant icon indicating copy to clipboard operation
elegant copied to clipboard

refactor(categories, comments): remove Bootstrap.js

Open hno2 opened this issue 4 years ago • 1 comments

Prerequisites

Recommended Steps

  • [ ] My patch adds a new feature, therefore I have also added a help article about it
  • [ ] My patch changes Elegant behavior, therefore I have updated the help article to reflect this change
  • [ ] My commits are signed

Description

Removing Bootstrap.js in the base.html requires a refactor to make the accordions on the categories page and in the comment section work correctly. This commit refactores the accordion with a hidden checkbox and some css. Additionally some JavaScript was changed to allow anchor linking to a specific category and opening it. The existing jQuery was refactored to vanilla js. This is part of the ongoing progress to remove Bootstrap completly in Pull Request #500 and Issue #429.

Thanks for your help in advance. Please be kind, this is my first real pull request to Open Source and I am not a JavaScript God. (Sorry for any mistakes, hope I followed all guidelines.)

hno2 avatar Aug 11 '20 16:08 hno2

Are there any issues with my Request or any ETA for when this can/will be merged ?

hno2 avatar Nov 21 '20 17:11 hno2