peerdb icon indicating copy to clipboard operation
peerdb copied to clipboard

explicitly call EnsurePullability while adding tables

Open heavycrystal opened this issue 1 year ago • 1 comments

The UI for dynamic table addition should prevent tables that we cannot mirror via CDC [no primary key + replident != full] to be selected. However, we end up using the signal for adding tables sometimes, and currently there is no check in this codepath.

Invoking EnsurePullability explicitly to guard against this.

heavycrystal avatar Feb 15 '24 12:02 heavycrystal

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 21 '24 16:05 CLAassistant