Pieter Hordijk

Results 23 comments of Pieter Hordijk

I like the idea of returning a response object, but I don't like introducing an external dependency.

Am I missing something here? The nonce in oauth is more used to prevent the service from processing the same request multiple times and not to prevent some security issue....

@azjezz how would you envision async support as no part of airship is build with non blocking support in mind?

Out of curiosity. Does this properly handle overridden styles? E.g.: *file1.css* body {font-family: xxx} *file2.css* body {font-family: yyy} *file3.css* body {font-family: xxx}

Also it seems this PR actually adds / changes two different unrelated things? You may want to split it up in 2 PRs if that is indeed the case.

> about PRs, i'm actually new to github however i created a new branch for the customization thing and separated them, i hope i did it the right way. No...

@MacFJA do you need / want help implementing this? No promises, but I may have some time looking into this in a couple of weeks.

PSR-what? Some? All? What does this lib gain by following PSR guidelines besides the fact you can use a nice buzzword in the read me?

I just don't like the blanket statements like: Use PSR without any reasoning. And without elaborating what is gained and / or what PSR you like to see implemented and...