pecan icon indicating copy to clipboard operation
pecan copied to clipboard

Dummy PR to check GA

Open allgandalf opened this issue 11 months ago • 4 comments

Description

Motivation and Context

Review Time Estimate

  • [ ] Immediately
  • [ ] Within one week
  • [ ] When possible

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] My name is in the list of CITATION.cff
  • [ ] I have updated the CHANGELOG.md.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

allgandalf avatar Mar 07 '24 18:03 allgandalf

@GandalfGwaihir I see this is marked as a dummy -- is it finished and OK to close?

infotroph avatar May 08 '24 16:05 infotroph

@GandalfGwaihir BTW I keep a sandbox copy of PEcAn at https://github.com/infotroph/pecan-pr-sandbox to I use for testing things that would otherwise clutter up the main repo -- use it if you'd like, but no obligation.

infotroph avatar May 08 '24 16:05 infotroph

Hold this please, We have a bug which adds tests label to every PR, I will get to that this month, will close this once the bug is sorted out, and sorry should had posted the update here! good times 🥂

allgandalf avatar May 08 '24 16:05 allgandalf

use it if you'd like, but no obligation.

Didn't know that, yeah sure, will test over there!

allgandalf avatar May 08 '24 16:05 allgandalf