pecan icon indicating copy to clipboard operation
pecan copied to clipboard
verified publisher icon PecanProject

WIP: Thredds download function

Open bailsofhay opened this issue 6 years ago • 7 comments

This function is the start of a general function that should be able to download data from THREDDS.

Description

The user can download any THREDDS datasets as long as they have site information, dates, and the base URLS needed to grab the datasets. Base URLS need the dataset name, but not the dates or locations. There will likely be issues pulling data sets in the future since they are not all stored in similarly structured directory formats like AVHRR LAI (which this function is based on). Updates to the function will occur as we start playing with more datasets from THREDDS.

Motivation and Context

We need an easy way to grab more datasets and THREDDS has many already, and is a great place to store future datasets that we can use.

Review Time Estimate

  • [ ] Immediately
  • [ ] Within one week
  • [X] When possible

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the CHANGELOG.md.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

bailsofhay avatar Oct 15 '19 20:10 bailsofhay

@ankurdesai I had to remove the earlier PR I made last week with the SDA file changes attached. this is the new PR for the same Thredds function, but without non-related file changes.

bailsofhay avatar Oct 15 '19 20:10 bailsofhay

Turns out there was already a branch named thredds that was messing up my pr....... :/

bailsofhay avatar Oct 15 '19 20:10 bailsofhay

Once merged this will close #2415, correct?

infotroph avatar Oct 16 '19 10:10 infotroph

@infotroph, @ashiklom or @mdietze. What is the standard way to code in warnings. For example, I want a warning to pop up and kill data extraction if the user puts in a date range that the data doesn't exist during.

bailsofhay avatar Oct 16 '19 16:10 bailsofhay

Warning, errors, and logs should be handled through the logger functions in the PEcAn.utils package

mdietze avatar Oct 16 '19 16:10 mdietze

This PR is stale because it has been open 365 days with no activity.

github-actions[bot] avatar Sep 10 '21 00:09 github-actions[bot]

Status: @serbinsh will replace this with an updated version as part of #2861, then close this when done

infotroph avatar Oct 22 '21 09:10 infotroph