CastingEssentials icon indicating copy to clipboard operation
CastingEssentials copied to clipboard

[Camera Tools] Inconsistent behaviour without index and dead players for same class

Open Wiethoofd opened this issue 5 years ago • 2 comments

Reproducible when there are 2 or more of each class using ce_cameratools_spec_class team class (without the optional [index]) and the first player in the list to cycle through to observe is dead.

Example 1 Example 2 Example 3 Example 4
BLU Soldier Alive Alive Alive Alive
RED Scout 1 Alive Dead Dead Alive
RED Scout 2 Alive Alive Dead Dead
RED Scout 3 Alive Alive Alive Alive

In every example we start on 'BLU Soldier' and repeatedly use the bind with ce_cameratools_spec_class red scout :ballot_box_with_check: Example 1: Changes from BLU Soldier to RED Scout 1 to 2 to 3 and back to 1 (as expected) :negative_squared_cross_mark: Example 2: Stays on BLU Soldier and does not swap to RED Scout 2 or 3; when 1 is dead :negative_squared_cross_mark: Example 3: Same as 2; stays on BLU Soldier to does not swap to any scout :black_square_button: Example 4: Changes from BLU Soldier to RED Scout 1 to 3 and back to 1

NB: have not been able to confirm example 4 in a live STV or demo, only in local server.

Wiethoofd avatar Jul 01 '19 22:07 Wiethoofd

Example STV demo

At the start a blue scout and red soldier in the first slots are dead and the 'team class' bind will not cycle through the players, but a 'team class 1' for the 2nd player on that class will swap to the correct POV.

Wiethoofd avatar Aug 30 '19 21:08 Wiethoofd

Fixed in https://github.com/dalegaard/CastingEssentials/commit/6c3440f76a8a1006c27505b94f8db6a595ccc797, ignores dead players when switching. You can cherry pick it from there, or I can make a PR if you prefer.

dalegaard avatar Aug 30 '19 21:08 dalegaard