fast_excel icon indicating copy to clipboard operation
fast_excel copied to clipboard

regenerate / update bindings

Open louim opened this issue 7 years ago • 3 comments

Hello!

I'm trying to access this enum, but it does not seem to exists in the binding. Maybe they need to be regenerated? Do you still have the command you used to generate the original binding?

louim avatar Apr 11 '18 19:04 louim

Hi, I don't remember a command but it was buggy and not structurized (all in one file). I will try to add that enum manually

Paxa avatar Apr 12 '18 18:04 Paxa

Hey! I'm not sure this is would be a good idea, since it will become very hard to keep in sync with the lib. I've also discovered that there was a couple of function that had been added since the initial import that were missing. I've regenerated the bindings in this branch. I know ffi_gen is a really old gem, but I think the best bet is to keep it working as long as possible.

Here's what I've done:

  • Created a Docker image running ruby and a compatible version of clang.
  • Added a rake task to regenerate the bindings.
  • Regenerated the bindings.

I kept it as simple as possible for now. Bindings are in a single file to be reproducible. I also removed headers that were generating incorrect code and third party headers.

I plan to submit a PR once I clean up the dockerfile to make it reproducible easily. What do you think?

louim avatar Apr 12 '18 18:04 louim

May be will use it in future. For now I added that enums manually https://github.com/Paxa/fast_excel/commit/40db3d1e034c5917b9df544793edfb863b3796a8

Paxa avatar Jun 16 '19 18:06 Paxa