PavelSharp

Results 23 comments of PavelSharp

Introduce minimal API for text keyboard request with text area and cursor support

This discussion started in #852, but it actually relates much more to this PR. ## PART 1 CLICK TO SHOW ### PavelSharp **News.** In the current version of this PR,...

nk_do_property() uses nk_strtod() instead of NK_STRTOD()

This indeed resolves the inconsistency that currently exists in Nuklear. In the code, the `NK_PROPERTY_FLOAT` branch calls `nk_strtof`: https://github.com/Immediate-Mode-UI/Nuklear/blob/fcd64f85e54b9d35eee13347748d70fa4d2e134e/src/nuklear_property.c#L278-L282 `nk_strtof` implementation is: https://github.com/Immediate-Mode-UI/Nuklear/blob/fcd64f85e54b9d35eee13347748d70fa4d2e134e/src/nuklear_util.c#L224-L232 Therefore, in the `NK_PROPERTY_DOUBLE` branch we should...

[CRITICAL] Fix clipboard text operations and UTF-8 cursor handling

Hi, @sleeptightAnsiC! Thank you for your comment - I really appreciate the feedback. I carefully reviewed your notes and started digging into the issue. While doing so, I actually discovered...

[CRITICAL] Fix clipboard text operations and UTF-8 cursor handling

@sleeptightAnsiC I may use LLMs to help phrase comments more clearly, but all code and reasoning are my own. Obviously, LLMs are very good at the task of writing in...

[CRITICAL] Fix clipboard text operations and UTF-8 cursor handling

@sleeptightAnsiC Concerns about LLM usage in this context appear to reflect a misunderstanding of how such tools are integrated into software development and debugging processes. When working with complex code,...

[CRITICAL] Fix clipboard text operations and UTF-8 cursor handling

@sleeptightAnsiC So, let’s talk specifically about the **clipboard copy bug**. The root cause lies in these lines: https://github.com/Immediate-Mode-UI/Nuklear/blob/fcd64f85e54b9d35eee13347748d70fa4d2e134e/src/nuklear_edit.c#L284-L291 Here we clearly see that `end - begin` is passed as the...

[CRITICAL] Fix clipboard text operations and UTF-8 cursor handling

@RobLoach I think this PR is finally ready to be merged! All the requested changes have been addressed, and all merge conflicts have been fully resolved. Also, as mentioned in...

[CRITICAL] Fix clipboard text operations and UTF-8 cursor handling

@sleeptightAnsiC > I didn't test the latest changes yet. The old comment doesn't really apply here, it's outdated. I'm sorry, but the only real code change since that [comment](https://github.com/Immediate-Mode-UI/Nuklear/pull/841#issuecomment-3419909743) is...

[CRITICAL] Fix clipboard text operations and UTF-8 cursor handling

Just to note, there have been a couple of previous attempts to address this: - #764, as @sleeptightAnsiC pointed in his [comment](https://github.com/Immediate-Mode-UI/Nuklear/issues/764#issuecomment-3538804587) - #543, where the author describes the same...

suspicious static checks for sizeof(nk_bool)

Good afternoon. Historically, Nuklear used `int` as the boolean type. Later, in PR #185, support for a dedicated boolean type (`nk_bool`) was introduced. A large number of files were updated...