mdx-embed icon indicating copy to clipboard operation
mdx-embed copied to clipboard

feat: add Microsoft Stream video component

Open gaelhameon opened this issue 3 years ago • 1 comments

Hi ! Thanks for this project ! I'd like to use it to embed videos hosted on Microsoft Stream so I added a component. Right now, I only created the Video component, but there are other objects in Microsoft Stream that can be embedded, like channels and groups, so I tried using a folder structure and naming convention that would make it easy to add those in the future. And I haven't looked into it too much yet, but I think it's possible to embed media from other Microsoft products too, so I created a specific folder for Stream.

I havent found any public stream videos and I don't think such a thing exists. I've limited the integration tests to checking if the sign in buttons appear. Locally, it works fine after that when I log in to stream with my company's credentials.

gaelhameon avatar Apr 18 '21 15:04 gaelhameon

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@08412dc). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage        ?   94.21%           
=======================================
  Files           ?       94           
  Lines           ?      795           
  Branches        ?      149           
=======================================
  Hits            ?      749           
  Misses          ?       11           
  Partials        ?       35           
Impacted Files Coverage Δ
...ed/src/components/mdx-embed-provider/components.ts 100.00% <100.00%> (ø)
...rc/components/microsoft/stream/ms-stream-video.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08412dc...7b33611. Read the comment docs.

codecov-commenter avatar Apr 18 '21 15:04 codecov-commenter