PaulWestenthanner

Results 72 comments of PaulWestenthanner

I've finally worked on this. This issue is a duplicate of #199 anyway right?

> self.cols = the features you are encoding > self.feature_names = all the features fed to the encoder regardless if you are doing encoding or not you're right. I missed...

The example given works now. Probably this was fixed when the whole `convert_input` functionality got refactored

checking in with this after some while: Can we close this issue? As of today all tests work for count encoder

Hi @Rishoban I'm very sorry for being so late to come back to this PR. I've done a lot of work on it and it now fits nicely into the...

closing this as I also agree that it would be out of scope

added in #222

Yes we could I think, that should be rather straight forward as well. Would you set `with_intercept=True` as a default for backwards compatibility or not (which might be more correct)?