PaulWestenthanner

Results 72 comments of PaulWestenthanner

Hi @PraveshKoirala this is not a bug. `fit_transform` calls `transform(X, y)` with the target information. As stated in catboost transform documentation > y : array-like, shape = [n_samples] when transform...

I'm not quite sure though why our implementation uses this cumsum and cumcount. With this the output is dependent on the ordering of the input. I'm not super deep into...

This has been fixed in the meantime. Thanks for your contribution anyway :)

Hi @slundberg could you please provide an example of the error? The example given in the doctest seems to work. I'm a little concerned to change this here since for...

This issue should be fixed by aligning the indices as merged in #320 @slundberg Could you please confirm?

Hi Carlos, I'm not exactly sure what your point of concern is here. Is it 1. a wording issue: Since it says `add noise` the noise has to be additive?...

plase have a look at the dicussion in #355 is this a duplicate of that issue?

I just created something, please review it whoever wants to. My draft does not add `feature_names_in` though

I just added the `get_features_names_in` function. There is however a rather nasty problem: The `self.cols` attribute is the same as `feature_names_in_` but we cannot just name it like this because...

ah that makes sense! Probably we should just drop support for versions < 1 by now