prb-math icon indicating copy to clipboard operation
prb-math copied to clipboard

Add sinus and cosinus for SD59x18

Open Amxx opened this issue 1 year ago • 3 comments

(work in progress)

Amxx avatar May 09 '24 16:05 Amxx

Note: https://github.com/mds1/solidity-trigonometry/blob/main/src/Trigonometry.sol should be considered. I don't understand the underlying logic, but if translated to signed integers, it might be cheaper / more accurate ?

Amxx avatar May 09 '24 16:05 Amxx

Hi @Amxx, thank you for your PR. I just wanted to say that it might take a few weeks (or more) until I'm able to review this.

The lint job appears to be failing. Have you run forge fmt locally? Using VSCode should automatically do this for you.

PaulRBerg avatar May 20 '24 08:05 PaulRBerg

@PaulRBerg Sure, not rush. There may be otehr implementations that deserves exploring anyway.

Amxx avatar May 20 '24 15:05 Amxx