Paul Berg comments

Results 723 comments of


                                            Paul Berg

Rename "SablierHelpers_" prefix to "SablierLockupHelpers"

If `Helpers` is meant to be used by other contracts, then it should be moved to evm-utils Otherwise, it makes sense to rename the error prefix to `SablierLockupHelpers_`.

Rename "SablierHelpers_" prefix to "SablierLockupHelpers"

good idea @smol-ninja - `LockupHelpers` and `LockupMath` sound good

chore: explain what `forge remove` does more specifically

Oh, yes. Should we move this to the `foundry` repo?

`max_test_reject_rate`: set a maximum test rejection rate per test function

I am with @0xPhaze, I would also find this feature useful. Related: #4085.

feat(useSortedKeys): add groupByNesting option

@coderabbitai generate docstrings

feat(useSortedKeys): add groupByNesting option

The CI has failed but I think it's related to the AWS outage today?

feat(useSortedKeys): add groupByNesting option

@ematipico saw you closed this, will this be implemented in another PR? How can I help?

feat(useSortedKeys): add groupByNesting option

Thanks for your feedback @ematipico - the PR is ready for reviewing again.

Feature request: transaction types

Don't have any other concrete suggestions, unfortunately

Thoughts on creating a "StdConstants" contract?

Well, simply being able to inherit from `StdConstants` and make use of the constants defined in Foundry without also getting the `vm` and the `stdstore` variables. I can't do this...