Paul Berg comments

Results 723 comments of


                                            Paul Berg

Guidance for address management when fork testing

Sharing Matt Solomon's insights from the Foundry Support group:

Improve documentation for `--fork-retry-backoff`

Related: https://github.com/foundry-rs/foundry/issues/4958

Document that `vm.expectRevert` should not be used for low-level calls

As @mds1 said in this [comment](https://github.com/foundry-rs/foundry/issues/1124#issuecomment-1082201763): > If so, then maybe the best path forward here is leaving as-is and updating the foundry book to mention you must assert on...

Clarifying what it means to "run all tests against the state resulting from your production deployment script"

Oh, but of course 😅 Sorry, I must have had a bit of brain fog when I opened the issue. Thanks also for sharing the example - all clear now....

Clarifying what it means to "run all tests against the state resulting from your production deployment script"

I have tried to implement this in my tests but it looks like broadcasting is not compatible with pranking: ```solidity FAIL. Reason: Setup failed: You have an active prank. Broadcasting...

Clarifying what it means to "run all tests against the state resulting from your production deployment script"

I'm pretty sure that I had a `vm.stopBroadcast` well before the calls to the prank cheatcodes. I will try to set up a reproducible example.

Clarifying what it means to "run all tests against the state resulting from your production deployment script"

@mds1 I have tried running my deployer scripts again and I bumped into the same problem, though I have been able refactor my tests to fix this. Here are the...

Clarifying what it means to "run all tests against the state resulting from your production deployment script"

What I *was* doing - that prank was a leftover from my previous test deployment flows. It just remained there. After removing it, I was able to use the scripts...

TypeError: Cannot read properties of undefined (reading 'address') at TrustWeb3Provider.setConfig

Hey @vikmeup, you should report and ban the user above with handle "Walletsupport". The Google Form they shared includes a field for scooping private keys:

TypeError: Cannot read properties of undefined (reading 'address') at TrustWeb3Provider.setConfig

@hewigovens in our case, this bug happens on web, specifically on [pay.sablier.finance](https://pay.sablier.finance).