Paul Berg

Hi @kadenzipfel, sorry for the long review time. I am happy to accept the changes introduced by this PR, because it is not a given that everybody will use `--via-ir`....

I managed to re-apply your changes on top of the `staging` branch myself, while preserving your git authorship. However, after a little bit of research and benchmarking on Remix, I...

I just bumped into the same problem. @fvictorio we might need another quick version bump for `solhint` to upgrade to the latest `@solidity-parser/parser`.

> take a look at https://github.com/lucas-manuel/invariant-example and https://github.com/foundry-rs/book/pull/760 Also [maple-core-v2](https://github.com/maple-labs/maple-core-v2).

> did this behavior change recently? No, it didn't. `selfdestruct` still doesn't remove the code of the destructed code until the test execution finishes.

> Is there any specific reason you need to test that the contract was self-destructed by checking the code size? I realize this may be an odd question. I am...

Shouldn't this issue be closed? It looks like #3128 added support for library coverage, and I can also see that it works in my project. **Update**: it looks like no,...

> Might be worth updating the issue with what is the current way of how coverage works. Cc @gakonst. Many coverage-related issues are outdated, including https://github.com/foundry-rs/foundry/issues/1961.

Thanks @elenadimitrova, great idea to ignore the tests in Codecov directly. However, it should be possible to do this with Forge itself - ideally, there would be a `--ignore` flag...

I have recently discovered several bugs in the coverage command. Posting here for cross-reference: - [ ] https://github.com/foundry-rs/foundry/issues/4294 - [x] https://github.com/foundry-rs/foundry/issues/4305 - [ ] https://github.com/foundry-rs/foundry/issues/4309 - [ ] https://github.com/foundry-rs/foundry/issues/4310 -...