jless icon indicating copy to clipboard operation
jless copied to clipboard

Syntax highlighting looks bad in certain color schemes

Open PaulJuliusMartinez opened this issue 3 years ago • 9 comments

The syntax highlighting looks bad in certain color schemes. Most notably, when using Solarized Dark, sometimes the background and foreground color are indistinguishable:

Gruvbox: gruvbox-jless

Solarized Dark: solarized-dark-jless solarized-dark-jless2

The highlighting of search results in the previews are invisible, and the text of currently focused object keys is also unreadable.

In general, the text of the currently focused object key is often unreadable.

I'm unsure of how to solve this well and respect the user's chosen color scheme by using only the base set of 16 colors. Handling light vs. dark modes is especially difficult. (Solarized is bad because all of its Bright variants are so close together.)

The current code uses a mix of dimmed and inverted mode, but these don't always work well together in all terminals / color schemes.

PaulJuliusMartinez avatar Feb 09 '22 10:02 PaulJuliusMartinez

Solarized Dark user on iterm here. I'm seeing the problem shown in your 3rd pic, ie. the highlighted key is illegible.

robinbowes avatar Feb 14 '22 23:02 robinbowes

selenized (solarized variation) light theme suffers from the same problem:

image

in general it's bad for legibility to use a colour for both the background and foreground at the same time.

wbolster avatar Feb 22 '22 15:02 wbolster

Another Solarized Light theme that looks bad: image

NightMachinery avatar Dec 23 '22 02:12 NightMachinery

image One Dark here, looks terrible. Even just being able to change which of the basic 16 colors it uses would be nice!

raiguard avatar Mar 22 '23 05:03 raiguard

If terminal uses low contrast color set there isn't much to do I guess.

Other than that I would like to propose utilizing JQ_COLORS variable.

Cheers 🍷

f6p avatar Jul 15 '23 11:07 f6p

Is there any news or information about customizing the color scheme here?

mortymacs avatar Dec 01 '23 11:12 mortymacs

Just a simple "black & white" and "white & black" color schemes would be nice as a low hanging fruit for a strart.

dmgr avatar Dec 21 '23 16:12 dmgr