semantic-version icon indicating copy to clipboard operation
semantic-version copied to clipboard

Merging 2 PR at same time with semantic version returns same version

Open Guriqbal-Singh-Alida opened this issue 3 years ago • 2 comments

Scenario: Merge 2 PRs, 1 right after another. 1 of the action runs and other one is waiting(by using concurrency: ${{ github.workflow }}) After 1st PR processing done it create new tag and pushes it but the when second PR runs after, it fails to pick up newly created tag returns the same old tag.

currently using v4.0.3 for action. Any help is appreciated

Guriqbal-Singh-Alida avatar Jun 21 '22 22:06 Guriqbal-Singh-Alida

I have this problem too, version does not increase

andyfcx avatar Jun 22 '22 09:06 andyfcx

So this action is going to be running entirely on the local copy of the repo, so any concurrency issues will need to be handled higher in the "stack". Having said that, normally this kind of concern would not be an issue since the intended use case/concept for this action is that the release is being created in a manual process (e.g. after a release passes QA, etc.), as opposed to automatically created tags. There is an option to increment each commit automatically that better supports this kind of process (each commit is a new version) and it would not require tags at all, though not sure when your repo is being pulled so this may or may not help.

If you can't lock this down and the conflict is in the "increment" portion of the version you might consider using the Git hash as the version tag suffix instead.

PaulHatch avatar Jun 22 '22 10:06 PaulHatch