Aegean icon indicating copy to clipboard operation
Aegean copied to clipboard

replace dependency on `lmfit` with scipy fitting

Open PaulHancock opened this issue 2 years ago • 1 comments

The module lmfit was used to allow fitting with constraints since scipy did not offer such a functionality at the time. Now that scipy.otimize.minimize now allows for constraints to be placed on individual parameters, lmfit is no longer needed.

PaulHancock avatar Jul 08 '22 05:07 PaulHancock

After some inspection of the scipy.optimize.minimize, I conclude that the interface is too different from lmfit to make the transition easy. minimize requires the target and jacobian functions to have the same call signature, which would required me to create a dictionary of the fitting parameters just like we do with lmfit. There seems to be little to be gained from this transition.

PaulHancock avatar Jul 18 '22 08:07 PaulHancock