SamRewritten icon indicating copy to clipboard operation
SamRewritten copied to clipboard

Cannot fetch proton games

Open SekoiaTree opened this issue 3 years ago • 7 comments

Any games that are run only through proton (i.e. have a windows version only) cannot be fetched. They don't appear in the list at all. Interestingly, games that are forced to run through proton but have a linux version are just fine.

They do not appear in the commandline --list-apps either.

Tested on a master build on Pop!_OS 21.10 (ubuntu derivative).

SekoiaTree avatar Apr 10 '22 11:04 SekoiaTree

After some testing, it doesn't seem to be verified as "installed". (SteamAppDAO::app_is_owned returns false). Potentially, we could use appmanifests to check for installed games in a more reliable way?

SekoiaTree avatar Apr 10 '22 11:04 SekoiaTree

Oh! Very interestingly, launching SamRewritten with "--app 753640 -p" (the number being the app id), even if the app is a proton app it works 100% fine! Good enough workaround for me, but gonna leave this open since... it's still true

SekoiaTree avatar Apr 10 '22 11:04 SekoiaTree

Hello, As for all games which have issues being detected, you can simply input the AppId in the search bar to launch it. If you are willing to make a pull request to parse app manifests in addition to the regular checking, feel free to do so!

Thanks!

PaulCombal avatar Apr 10 '22 14:04 PaulCombal

Ah, good to know, thanks!

SekoiaTree avatar Apr 10 '22 16:04 SekoiaTree

@PaulCombal I am on Fedora Workstation 36, using the native Steam package from RPM Fusion, and the latest SamRewritten built from source. It lists 100% of my Steam games (as far as I can tell), even the ones that are windows only, not installed yet, etc. Works absolutely perfectly for me!

But good to know that I can launch it with a direct appid if something is ever missing.

Thank you so freaking much for creating this application. I love you.

Arcitec avatar Jun 16 '22 20:06 Arcitec

I can confirm that some proton only games don't show up (at least for me). In my case for example:

  • Control
  • Apotheorasis
  • Judgment
  • Lost Judgment
  • Watchdogs
  • Star Wars Fallen Order

But then things like Horizon, Hellblade, Plague Tale, Nier Automata et al. show up fine which makes me think this is a game integration issue with steam, not a problem of SR.

Again, as someone said earlier, running SR directly with the AppID works fine. Just my two cents.

oscarcp avatar Nov 12 '22 21:11 oscarcp

“Dagon” (1481400) is in the lists as far as what is being given to the app in update_name_database but somewhere between that function and parse_app_names is where the bug is. A bit too busy to look at it.

Edit: Quick glance suggests update_name_database may be broken. Edit: Forcing retrieval_strategy = 3 allows all of mine to be detected, “Dagon” included.

OdinVex avatar Dec 20 '22 23:12 OdinVex