Paul Boon

Results 27 comments of Paul Boon

@pdurbin Should be OK now. BTW the added code is just the same as in getRequiredValueFromAssertion.

Testing is difficult because we don't have a testIdp where we can fake an affiliation. But now that I had a peek at the code change, I do see it...

@ofahimIQSS I was hoping someone involved with the original issue or code for the `getRequiredValueFromAssertion` could test it.

@ofahimIQSS Sorry for my late reply, I tend to ignore my mailbox regulary. About the login, the dropdown with institutes looks fine, but I can not find my institute (DANS),...

@pdurbin That you could not reproduce the problem might have to do with the input, I mean that string was probably all ready in UTF-8 when you entered it?

Unless I made a copy error, it should work because I assume the existing code in `getRequiredValueFromAssertion` is correct, which I copied into `getValueFromAssertion`. So, testing is gold, but we...

@sekmiller hope it's OK now.

> @PaulBoon One thing that I noticed - if I use the multiple file download button when one of the files I have selected is no longer available due to...

@qqmyers Just added the release notes, and as with most of this PR I reused yours. I will wait for that other PR to be merged while I am on...

> ![Screen Shot 2024-04-30 at 3 42 03 PM](https://private-user-images.githubusercontent.com/2364928/326959421-faa38dec-05ea-4339-9573-13e5c1230362.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ1MDY1MjksIm5iZiI6MTcxNDUwNjIyOSwicGF0aCI6Ii8yMzY0OTI4LzMyNjk1OTQyMS1mYWEzOGRlYy0wNWVhLTQzMzktOTU3My0xM2U1YzEyMzAzNjIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDQzMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA0MzBUMTk0MzQ5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODcxZjU0NzMzMzQzYjJlNjkwYjQ5ZjdhMzA4ZGE2MjU3MTg3Yzc0YjljNWE0OTgwYzk4MTM1NmFiNGU1YjRkMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Ak5CeHX8B3VskLG79V3TOu6_f0BAhiXo3IYGBZQfHxw) > > On the dataset page file list - It looks like you should add a space or punctuation between the...