Patterns icon indicating copy to clipboard operation
Patterns copied to clipboard

fix(pat navigation): Don't check query string and hash fragments.

Open thet opened this issue 3 years ago • 2 comments

When setting navigation markers based on URL comparison do not set the query string and hash fragments. When using hash navigation within one page, use pat-scroll to mark items as current.

This fixes a problem described in: https://github.com/euphorie/Euphorie/pull/447#issuecomment-1259660758

It has the drawback that URL based detection of the current item when using navigation based on query strings or hash fragments (e.g. a table of contents) would not be possible anymore. But that might be corner cases.

thet avatar Sep 28 '22 15:09 thet

Did you consider Ale's suggestion of making this configurable?

reinhardt avatar Sep 29 '22 14:09 reinhardt

Will do that

thet avatar Sep 29 '22 15:09 thet