redis-dataloader icon indicating copy to clipboard operation
redis-dataloader copied to clipboard

Published 20 hours ago • verified publisher icon PatrickJS

Typescript compability

Open volbrene opened this issue 5 years ago • 13 comments

Hello, nice project! Is is possible to add typescript compability for this project?

volbrene avatar Jan 14 '20 08:01 volbrene

yeah I can add that

PatrickJS avatar Aug 16 '20 19:08 PatrickJS

Any word on this? Happy to contribute if needed

dwelch2344 avatar Dec 07 '21 18:12 dwelch2344

At this point, I think we would have to contribute to making this happen. Which I am fine with. But is this project even active anymore @PatrickJS ?

nmaves avatar Jun 23 '22 16:06 nmaves

I talked with @PatrickJS via twitter and he would love to get a PR in for TypeScript. @dwelch2344 you got any time to help with this?

nmaves avatar Jun 27 '22 13:06 nmaves

@nmaves absolutely! ping me on twitter at david_welch!

dwelch2344 avatar Jul 11 '22 14:07 dwelch2344

@PatrickJS @nmaves @dwelch2344 Did anything come of this?

sutt0n avatar Jan 16 '24 19:01 sutt0n

Timing's amazing. Sadly not, but we're just implementing our data loader strategy at work now and so this bubbled up last week.

We're on the fence of a PR/rewrite vs just contributing TypeDefs. The lib's small enough and the world of TS in 2024 is pretty appealing...

dwelch2344 avatar Jan 16 '24 20:01 dwelch2344

@dwelch2344 if you want we can work together on the rewrite and then I can publish it as the new version and add whoever is working on it to the repo and package.

PatrickJS avatar Jan 16 '24 22:01 PatrickJS

@PatrickJS would love to! DMing ya on the bird

dwelch2344 avatar Jan 18 '24 23:01 dwelch2344

I'd be down to get involved as well. Bird handle is the same as GH.

sutt0n avatar Jan 22 '24 15:01 sutt0n

@sutt0n awesome! talked with @patrickjs and we're gonna split the work.

I'm going to setup a fork with a clean branch and a simple tsconfig project. Will add a proposed interface for the loader lib, and a few unit tests.

Will open a PR so we can all comment on the desired shape / etc, then can hash out the impl.

Sound good?

dwelch2344 avatar Jan 22 '24 15:01 dwelch2344

@dwelch2344 Sounds good!

sutt0n avatar Jan 23 '24 21:01 sutt0n

If I lose track of this it's because notifications are lost. And DM on twitter for fast response

PatrickJS avatar Jan 30 '24 07:01 PatrickJS