[WIP] [Lookup Anything] Look up a body of water to see fishing data

[b3nk3lly]

Added FishingAreaSubject, which displays data about a body of water. It inherits from TileSubject. It makes use of FishSpawnRulesField.cs to display a list of fish and their spawning conditions. Closes https://github.com/Pathoschild/StardewMods/issues/42.

So far, the FishingAreaSubject displays the fish that can spawn on a particular fishable tile. Only the spawn conditions are shown (no spawn percentage chance yet, or any crab pot data).

I added a progression mode option to hide spawn info for fish that the player hasn't caught yet. This also applies to lookups on fish.

There is currently a bug causing some spawn location names to appear as empty strings. I submitted a fix for that here: https://github.com/Pathoschild/StardewMods/pull/1035

Other technical changes:

• Added CheckboxList class, with inner classes Intro and Checkbox
• Replaced instances of KeyValuePair<IFormattedText[], bool> with the new Checkbox class
• CheckboxListField now supports multiple checkbox lists
• CheckboxListField now supports drawing a sprite in the list intro

Screenshots:

Currently, legendary fish like the Glacierfish are shown only when the player is in range of the fish's spawn point.

[b3nk3lly]

This is not finished yet - I still have some kinks to work out with the mineshaft floors. Any feedback is much appreciated !

[b3nk3lly]

This is not finished yet - I still have some kinks to work out with the mineshaft floors. Any feedback is much appreciated !

Mine-related bugs are fixed, taking this out of WIP :)

[Pathoschild]

@b3nk3lly I'm looking to add this in the upcoming Lookup Anything 1.50.0, but unfortunately it's a bit hard to merge since it changes a lot and has merge conflicts.

Any chance you could...

• submit a separate PR for the checkbox refactor;
• then (when it's merged) submit a new PR for the feature based on the latest develop branch?

[b3nk3lly]

@b3nk3lly I'm looking to add this in the upcoming Lookup Anything 1.50.0, but unfortunately it's a bit hard to merge since it changes a lot and has merge conflicts.

Any chance you could...

• submit a separate PR for the checkbox refactor;
• then (when it's merged) submit a new PR for the feature based on the latest develop branch?

@Pathoschild yes good plan, I will do that !

[b3nk3lly]

Closing this & resubmitting in multiple PRs. I opened #1093 to add the CheckboxList model. Will open another one for the fishing tile lookup, and a separate one for the new progression mode option