PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Increased ES implicits apply locally instead of globally

Open ghost opened this issue 5 years ago • 4 comments

Recently upgraded my Alpha's Howl for one with the % increased ES corruption and discovered that PoB doesn't reflect this change; ES stays identical regardless of which helm I use. I can confirm that the ES is in fact increased in game. image image

Here's the pastebin if you want to test for yourself https://pastebin.com/0Y9GLxUp

ghost avatar Jan 01 '20 20:01 ghost

The corruption mod is being applied locally instead of globally. Other sources of "increased maximum energy shield" mods are only available on jewellery which are correctly treating it as global. I'm a bit confused as to how the mods are being parsed differently.

meatballing avatar Feb 19 '20 14:02 meatballing

Looking at this again, we can maybe look at the "Local" field on a stat from the GGPK, and tag the line as such, but that only works when adding corrupted mods from PoB itself. When importing a character or copying an item, we'll have to cross-reference the implicit (only on corrupted items, to exclude synthesized mods) with the corrupted mods to find a match, and still might have false positives from Synthesis items.

Wires77 avatar Apr 15 '21 17:04 Wires77

I had the same error as others with the EoW increased ES. Came to report but it's already been done. Workaround is to add custom modifier "X% increased global energy shield" to the item.

Oddly, PoB doesn't miscalculate the local number. The EoW implicit is just ignored.

OzoneOOO avatar Sep 28 '22 23:09 OzoneOOO

These mods have slightly different wording the corrupted mod is x% increased maximum energy shield whereas the local one is always x% increased energy shield. This should be fixable by a special mod passing for x% increased maximum energy shield to always apply globally. E.g. this mod is also found on rings and applies globally.

QuickStick123 avatar Sep 29 '22 00:09 QuickStick123