Arkhon's tools, Ancestral Vision and added spell suppression Evasion Mastery leads to incorrect ailment status

[danielztolnai]

Check version

• [x] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• [x] I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

• [x] I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Linux - Wine

What is the value from the calculation in-game?

The game takes the +15% chance to Suppress Spell Damage if Equipped Helmet, Body Armour, Gloves, and Boots all have Evasion Rating mastery into consideration when calculating the elemental ailment avoidance with Ancestral Vision and therefore you will not be afflicted by elemental ailments.

What is the value from the calculation in Path of Building?

Path of Building does not take this mastery into consideration when calculating elemental ailment avoidance.

The reason for this is that the suppression added by the mastery is dependent on the gear you have equipped and the calculation for that is not done when the ailment avoidance is determined.

(lines of code mentioned below are taken from tag v2.59.2)

• Ailment avoidance is calculated on line 3224 in doActorMisc: https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/v2.59.2/src/Modules/CalcPerform.lua#L3224
• The spell suppression from the mastery is only added a later, on line 3389 in calcs.defence: https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/v2.59.2/src/Modules/CalcPerform.lua#L3389

How to reproduce the issue

• 1.) Equip an Ancestral Vision with Modifiers to Chance to Suppress Spell Damage also apply to Chance to Avoid Elemental Ailments at 50% of their Value.
• 2.) Allocate the +15% chance to Suppress Spell Damage if Equipped Helmet, Body Armour, Gloves, and Boots all have Evasion Rating choice for an Evasion Mastery.
• 3.) Make sure you have >=100% Chance to Avoid Elemental Ailments with the Evasion Mastery from 2.) enabled, but not without it.
• 4.) Enable Summon Skitterbots
• 5.) Equip Arkhon's Tools

Result: PoB considers you afflicted with all Skitterbot ailments while in reality you are not.

PoB for PoE1 build code

https://pobb.in/mLdCGe4ojsq-

Screenshots

No response