PathOfBuilding
                                
                                 PathOfBuilding copied to clipboard
                                
                                    PathOfBuilding copied to clipboard
                            
                            
                            
                        Fix minion skill type issues causing mod compatiblity issues
Closes https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/8718
Supersedes https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8707
Description of the problem being solved:
https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4628 removed condition allowing support gems to be compatible based on summoning gem skill types to fix application of mods that shouldn't apply. This caused many issues referenced in the thread of that PR. This pr attempts to improve the minion mod/support gem compatibility logic by implementing mod filtering based on exported flag and tweaks to the responsible function: calcLib.canGrantedEffectSupportActiveSkill
Marking as WIP/Draft as the problem of item mods still remains. Not sure if it'll end up being a separate PR.
Steps taken to verify a working solution:
- Test https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/4497
- Test https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/5302
- Test https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/5745
- Test https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8707
Link to a build that showcases this PR:
See links above for test builds