PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Added and dmg convertion completely wrong on many different skills

Open TerohsLab opened this issue 6 months ago • 2 comments

Check version

  • [x] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • [x] I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

  • [x] I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Linux - Wine

What is the value from the calculation in-game?

Will hijack this to post system details :

Up to date Tumbleweed KDE

  • Kernel 6.15.0
  • KDE Plasma 6.3.5
  • Wine 10.0.4.1
  • Wine-mono 9.4.0.1.7

Running wayland, but not forcing it on PoB.

What is the value from the calculation in Path of Building?

Example 1 - https://pobb.in/G2Izw_kkrBa4

Its a simple Witchhunter's Judgement ( Oshabi staff ) with Storm Brand and Brand Surge ( the skill oshabi staff gives ) is showing +5 min and +5 max dmg from something called "Sacrificial Zeal" and does not convert the dmg at all.

And i SWEAR that pob used to support Brand Surge ( even the escalating properties of it ).

It feels like in some git commit, someone accidentally rolled back all the work that was ever done on Brand Surge. Even the AoE used to show the ring.

Example 2 - https://pobb.in/EmZMxrFNoHqs

  • https://i.imgur.com/h2sQmwO.png
  • https://i.imgur.com/9KH7MQH.png

It does the conversion correct, but everything in that window is still not correct.

Example 3 - https://pobb.in/w9F0oGbpqDeI

  • https://i.imgur.com/23aV9vz.png
  • https://i.imgur.com/hYaIhls.png

An Necro with Unholy Might node and minions. I'm not sure how conversion works here, but i assumed its Skill > tree > item

Still the same issue with added dmg screen being wrong tho.

How to reproduce the issue

No response

PoB for PoE1 build code

They are linked above.

Screenshots

No response

TerohsLab avatar Jun 10 '25 20:06 TerohsLab

The Sacrificial Zeal bug was fixed on the beta branch in #8616

Wires77 avatar Jun 10 '25 20:06 Wires77

The Sacrificial Zeal bug was fixed on the beta branch in #8616

Good to know. Reminds me : I'm running the 2.52.3 stable vision and not using the flatpak version.

TerohsLab avatar Jun 10 '25 20:06 TerohsLab