PathOfBuildingCommunity
Port Trader Changes from PoB 2
Description of the problem being solved:
This refactors how inverted mods are handled, and does away with saving the sign value and subType. This means there is a new section called Talismans.
Implicits has been refactored and now uses ProcessMod this stops them applying to stuff they shouldn't and don't spam the QueryMods with subType stuff.
Several negative value mods now work correctly and some mods that might've been parsed correctly on an item should work for weight generation.
POSESSID is automatically expired.
HTML passed queries were removed in favor of API due to receiving constant 403 from them. This means realmIds and names were hardcoded but this shouldn't be an issue as they are infrequently updated.
Generation no longer uses invert and instead negative values are parsed in the stat weight which is handled by building values in queryMods.
The sign appearing might not be the most correct since it assumes that if a mod appears on the trade site with a + it will have one but there are cases where this isn't the case this can be seen in PoE 2 quite commonly but probably isn't a big deal here. Ideally using their stat descriptions would be ideal to determine this.
Does this branch work correctly for Path of Exile 2, allowing characters to be imported?
No these changes are for PoE 1 version of the client I just ported the improvements I made back to the PoE 1 side, afaik there is no way to import characters currently for poe 2 even in our dev environment due to lacking apis.
This has an issue regarding parsing of mods that don't match with signage on trade mods. It is a fairly noticeable problem for the poe 2 client but probably won't cause to many problems here but I will mark it as a draft anyways.
Does FetchLeagues support getting the user's private leagues?
If so, may I suggest breaking out the query fixes into their own PR so we can benefit from them, while you figure out your mod issues?
