PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Change Passes to only always, never or average crit chance

Open Regisle opened this issue 5 months ago • 0 comments

This is mostly a background change for a minor performance boost and to change what is displayed on the calcs page

This is mostly for something like plume of pursuit, which has an 80% less damage multiplier for non crits, but for the hits you care about it will always be a crit, this also will show inquisitors inevitable judgement ignore res instead of pen if your guaranteed to crit.

I have been sitting on this for a while and couldnt find any issues on any builds I tested, but it likely needs to be tested on more builds incase there is an issue. This also sets the crit skillCond as late as it can to prevent other issues, so that it doesnt impact any calculations, and only does it if its certain it will apply (100% chance), this could be changed to show in the average case (eg if crit chance is >= 50%) as its after all relevant calculations are done, but decided to be conservative

Regisle avatar Aug 30 '24 08:08 Regisle