PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Fix crash caused by Call to Arms conversion

Open Paliak opened this issue 1 year ago • 0 comments

Description of the problem being solved:

Call to Arms tattoo has been converted to Warlord's Call. This caused a dismissable crash on importing a build that had one slotted. Finding which tattoo converts to which is quite hard without adding historical tattoo data or some kind of conversion table.

This pr adds logic that attempts to find the new name by comparing available stats. Failing that it removes the tattoo to prevent crash. Added logging in both cases.

Steps taken to verify a working solution:

  • Try importing the following builds:
https://pobb.in/F7sdQa4QPD2_
https://pobb.in/m8iRz-fn3uuF
https://pobb.in/9ACP67JVEGy0

Paliak avatar Apr 08 '24 23:04 Paliak