PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Add a tooltip stat-diff toggle to Items tab

Open Nightblade opened this issue 1 year ago • 5 comments

Fixes #n/a.

Description of the problem being solved:

Adds a keyboard shortcut to toggle tooltip generation off/on in the Items tab, in response to a user's request to add a manual-calculation mode and button, or something of that nature.

The shortcut, and tip-text, are taken from the Tree tab: Ctrl+d

This was the simplest code-change (hack) I could see at the time, and while it does solve the user's issue in a roundabout way, I realise there are good reasons why this PR may end up rejected.

A better way might have been to intercept recalculation requests and only recalc when a hotkey is used, but that seemed rather involved at first glance.

Steps taken to verify a working solution:

Tested with user's build code on current dev branch of pob.

Link to a build that showcases this PR:

https://pobb.in/LhJE9HFWkVWX (purely experimental)

Before screenshot:

image

After screenshot:

image

edit: updated "After screenshot" to latest version

Nightblade avatar Jan 20 '24 09:01 Nightblade

Does this speed up hovering jewels in involved builds by a lot? To have a chance of approval, this would still need to show the stats on the jewel (just not the comparison) and the Ctrl+D text on the normal tooltip so users know the feature exists.

Wires77 avatar Jan 20 '24 15:01 Wires77

Does this speed up hovering jewels in involved builds by a lot?

Yes, on my PC at least.

 

To have a chance of approval, this would still need to show the stats on the jewel (just not the comparison)

Done.

Nightblade avatar Jan 21 '24 00:01 Nightblade

Actually, I may have spoken too soon regarding my capabilities. I'll have a go at it.

Nightblade avatar Jan 21 '24 00:01 Nightblade

Wasn't actually that hard yay! image

Nightblade avatar Jan 21 '24 01:01 Nightblade

Added code to save/load the setting between sessions; PR read for review.

Nightblade avatar Jan 24 '24 02:01 Nightblade

Another benefit of this enhancement is visibility when running pob at reduced horizontal resolution with a lot of jewels in your passive tree:

before image

after image

Nightblade avatar Jun 07 '24 02:06 Nightblade