PathOfBuildingCommunity
Don't save default minion skill set choice
Description of the problem being solved:
Default minion skillset was being saved to skills triggering phantasm support causing the default minion skill set to spread like a disease in build save files.
Marking as draft as while rather innocent still sort of worried it may break some edge case.
https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5700 https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5571 https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5697
Here are some related PRs.
AFAIK this should only be occurring with disabled skills/vaal skills atm. #5700 has details on the issues I still found with it.
@QuickStick123 This happens with all skills. This is caused by the drop down sorting functionality adding the summon phantasms support which saves the default selection of minion skill in the drop down to the skillInstance which is then later saved to the build xml.
Do you have some replication steps? I was under the impression I fixed this for everything except vaal skills which is fixed in https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5700.
The only othercases are with disabled skills or oddities on support gems.
The disabled skills could probably fixed by calling the build functions on all skills before saving.
This now causes the minion selection to not be saved to build xml which is probably not worth the minor build xml bloating. Closing in favor of https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5700 (and to clean up the opened prs a bit)