PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Add support for Fleshcrafter minion life conversion

Open komarukun opened this issue 2 years ago • 2 comments

This requires a change to compute minion resistances before life. Player resistances must be computed after auras, so the calc pipeline isn't equivalent for the two actors. It looks like there's already separate handling for minions, so the main change is that section.

Also fixes #6149.

Description of the problem being solved:

Fleshcrafter minion life conversion is currently unsupported

Steps taken to verify a working solution:

  • Use Fleshcrafter in build
  • Check life/ES values after changing minion chaos resistance on gear/tree

Link to a build that showcases this PR:

https://pobb.in/iUOglRJrlnB0

Before screenshot:

No minion life converted to ES image

After screenshot:

Now minion shows life converted to ES: image If the minion has over 50% chaos res, life shows as 0: image Added warning for current active minion if all life is converted: image

komarukun avatar Sep 12 '23 12:09 komarukun

hey @LocalIdentity , could I get another look at my comment above/new commit when you get a chance? ty

komarukun avatar Sep 17 '23 17:09 komarukun

Alternative branch using https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/7370: https://github.com/Paliak/PathOfBuilding/tree/komarukun-fleshcrafter

Paliak avatar Mar 02 '24 17:03 Paliak