PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Add option to only compare stats for same jewel types.

Open michelrtm opened this issue 1 year ago • 3 comments

Fixes #6275 .

Description of the problem being solved:

When hovering on non-restricted (like timeless jewels) and non-cluster jewels in POB the tooltip that compares the benefits and drawbacks of adding the jewel to the build compares them to cluster jewels as well as per the image below: image

Steps taken to verify a working solution:

  • Tested enabling and disabling new option
  • Tested with hovering on existing jewels on the build with new option enabled and disabled
  • Tested with adding new jewel to the build with the option enabled and disabled: image Tooltip with option enabled.

image Tooltip with option disabled.

Link to a build that showcases this PR:

https://pobb.in/fX8QA_1MH4ve

Before screenshot:

image Cluster jewels present in tooltip.

After screenshot:

image New option added to the options screen.

image Cluster jewels no longer present in toolip.

michelrtm avatar Aug 11 '23 09:08 michelrtm

I realized I forgot Abyss Jewels in the tests above, here is a new POB link which includes Abyss Jewels: https://pobb.in/sf95K0iZx9Bh

And some tests that I ran: image Option disabled, Abyss Jewels also show on tooltip.

image Option enabled, only jewels of the same type and subtype included in comparison.

image Adding Abyss Jewels only compares with existing abyss jewels.

michelrtm avatar Aug 11 '23 09:08 michelrtm

@michelrtm Hi, are you going to resolve branch conflict?

justjuangui avatar Dec 16 '23 16:12 justjuangui

Would love to see this get finished. Is there someone currently working on it?

Glorithan avatar Jan 18 '24 18:01 Glorithan