PathOfBuilding
PathOfBuilding copied to clipboard
Add option to only compare stats for same jewel types.
Fixes #6275 .
Description of the problem being solved:
When hovering on non-restricted (like timeless jewels) and non-cluster jewels in POB the tooltip that compares the benefits and drawbacks of adding the jewel to the build compares them to cluster jewels as well as per the image below:
Steps taken to verify a working solution:
- Tested enabling and disabling new option
- Tested with hovering on existing jewels on the build with new option enabled and disabled
- Tested with adding new jewel to the build with the option enabled and disabled:
Tooltip with option enabled.
Tooltip with option disabled.
Link to a build that showcases this PR:
https://pobb.in/fX8QA_1MH4ve
Before screenshot:
Cluster jewels present in tooltip.
After screenshot:
New option added to the options screen.
Cluster jewels no longer present in toolip.
I realized I forgot Abyss Jewels in the tests above, here is a new POB link which includes Abyss Jewels: https://pobb.in/sf95K0iZx9Bh
And some tests that I ran:
Option disabled, Abyss Jewels also show on tooltip.
Option enabled, only jewels of the same type and subtype included in comparison.
Adding Abyss Jewels only compares with existing abyss jewels.
@michelrtm Hi, are you going to resolve branch conflict?
Would love to see this get finished. Is there someone currently working on it?