PathOfBuilding
PathOfBuilding copied to clipboard
Trade Finder: Add "Configure" button + window to allow selection of stats to optimize for, alla Node Power.
Check for duplicates
- [X] I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
No.
Describe the solution you'd like
Currently, the trade finder seems to optimize for overall dps when searching for build upgrades. However, sometimes I don't want to scale all of my dps, just certain stats. I'm currently playing a build that scales ignite damage, however the item finder is giving me weights for things like on-hit elemental damage, which helps on paper but is not what I might be trying to optimize for.
I propose adding a "Configure" box in-between the url text and the "Price item" button.
Clicking this button would pull up a configuration window per-item which would allow users to configure their searches for that specific slot. The user can then enable or disable certain stats the optimizer is optimizing for, for example, I might disable everything EXCEPT for Ignite DPS, so now all my searches for, say, my rings, optimize for that one stat. You could even have a custom user-editable "Weight" value to allow users to manually adjust the weighting they would like per-stat, so if I want to mainly scale ignite dps, but wouldnt mind additional on-hit elemental, I could weigh Ignite DPS to 3 and Average Hit to 2 (Or something like that).
If the item finder ever updates to include things like defensive stats, this would enable searching for specific offensive and defensive stats, like if you know your gear piece needs resistances and life, you can weigh that with scaling your dps as well.
Describe alternatives you've considered
Currently you have to manually cull out unwanted stats and manually add defensive stats to each search to get the results I want. Not unbearable, but not idea.
Additional context
Giving a skim at the code, it looks like we just optimize for the output's full dps/total dps, could we not add some categories to simply include/ignore in the UI to determine what we care about? We know the state of the build after each "test", so you can theoretically test for changes against any single stat if you'd like, instead of just total dps.
Implemented in https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5525