PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Add missing tags to Chaos Aura skill that Chaos Golem uses.

Open Paliak opened this issue 2 years ago • 1 comments

Fixes #5313 .

Description of the problem being solved:

Some minion skills seem to be missing flags and it's causing issues after https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4628 was merged.

~~Still need to check that the template minion.txt file does not cause issues with exports.~~

Paliak avatar Dec 13 '22 15:12 Paliak

This certainly works, but breaks if other things about the skill get updated in the future. I'd love to see an attempt at finding where the support gem flag hooks up to the damage for these types of skills to fix them properly. (or pursue the exclusion logic that was mentioned in Discord: https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/3932 )

Wires77 avatar Dec 14 '22 05:12 Wires77

Just wanted to mention that Stone Golem's Slam seems to be affected as well. It is not being supported by Multistrike, Melee Physical Damage, or Ruthless, to name a few.

divedev avatar Dec 23 '22 19:12 divedev

shouldn't addskill be addSkill for naming consistency?

Nightblade avatar Dec 24 '22 01:12 Nightblade