PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Published 20 hours ago • verified publisher icon PathOfBuildingCommunity

PoB no longer able to fetch characters for private accounts

Open TwentyFiveEx opened this issue 2 years ago • 3 comments

Check version

  • [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • [X] I've checked for duplicate issues by using the search function of the issue tracker

How is Path of Building expected to behave?

I should be able to provide a valid POESESSID and list my characters for my private account

How does Path of Building behave?

When providing a valid POESESSID for my private account I cannot list characters on that account, I received an error "Account is private".

How to reproduce the issue

  1. Set account+character tabs to private, through pathofexile.com account management
  2. Log into pathofexile.com and gather a current POESESSID
  3. Open PoB and import characters for the related account, providing the POESESSID
  4. Observe the "account is private" error.

Character build code

No response

Screenshots

image image image

I have also logged a bug on pathofexile.com, but the customer service folks moved it from the bugs forum to the "gameplay help" forum. https://www.pathofexile.com/forum/view-thread/3326049

TwentyFiveEx avatar Dec 10 '22 20:12 TwentyFiveEx

Comparing back to 2.21.1 {the last PoB release for 3.19} vs current 2.23.0, this logic change may have been introduced the bug in the 2.20.0 release, in file ImportTab.lua, as of yesterday

https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.21.1...v2.23.0#diff-9c92f7ea8e0528b99067d974565d47e61b86fb3c1eb98961299b511f9be7fe5bL452-L456

image

Related pull request: https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5171

TwentyFiveEx avatar Dec 10 '22 20:12 TwentyFiveEx

That is the correct segment of code, just the wrong PR you've linked to. A workaround would be to go into the trading pop-up on the Items tab and enter your session ID there. It now is persisted in your settings so you don't have to enter it every time.

Wires77 avatar Dec 10 '22 23:12 Wires77

@Wires77 Ah, oops. Yeah I'll dig some more in a bit, find the relevant PR, and see if I can't submit a new PR that both satisfies the original intent of the change while also not breaking lookups for private account (without the workaround). Thanks!

Note: Tested workaround and it does work for now. 👍

TwentyFiveEx avatar Dec 10 '22 23:12 TwentyFiveEx

@Wires77 thanks! just getting around to looking at this and.. already done. you are fantastic. <3

TwentyFiveEx avatar Dec 14 '22 16:12 TwentyFiveEx