PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

fix: Fix Kalisa's Grace crit chance modifier not working.

Open michelrtm opened this issue 2 years ago • 3 comments

Fixes #2813

Description of the problem being solved:

Kalisa's Grace Crit Chance modifier wasn't supported as per the linked issue.

Steps taken to verify a working solution:

  • Verified Crit Chance is unmodified when the item is added to the build
  • Changed the Mana Spent recently to 800
  • Verified that the Crit Chance modifier had increased by 2%

Link to a build that showcases this PR:

N/A

Before screenshot:

Before Modifier is unsupported.

After screenshot:

Test1 Modifier now supported.

Test2 When mana spent is below threshold, no crit chance is added.

Test3 When mana is above threshold, crit chance is increased by 2%.

michelrtm avatar Oct 01 '22 23:10 michelrtm

The correct in-game wording is for 2 seconds after Spending a total of 800 mana btw, so the unique wording needs to be updated as well (on top of using correct wording for parsing)

deathbeam avatar Oct 01 '22 23:10 deathbeam

Thanks @deathbeam , I'll include that fix in this PR too.

michelrtm avatar Oct 02 '22 00:10 michelrtm

@deathbeam I've just pushed some changes to fix the item's Mod and for the changes to work with the new Mod text. I've ran through the same steps as in the PR description and still experiencing the same success. I was trying to test the original mod parsing with the 4 seconds but it seemed to be for the Weave the Arcane Trickster ascendancy passive which has been removed from the tree.

michelrtm avatar Oct 02 '22 21:10 michelrtm