PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Correct Fanaticism tooltip

Open MeDott29 opened this issue 2 years ago • 5 comments

changed mana cost to skill cost

Fixes # .

Description of the problem being solved:

Steps taken to verify a working solution:

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

MeDott29 avatar Sep 22 '22 14:09 MeDott29

did I miss anything in my submission?

MeDott29 avatar Sep 22 '22 14:09 MeDott29

Also you probably could clean up the description of your pr.

Paliak avatar Sep 26 '22 01:09 Paliak

In the code these mods are flagged as casts instead of spells and only work on self cast? I don't know if this will causes issues either. https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/2347 https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/1834

if modDB:Flag(nil, "Fanaticism") and actor.mainSkill and actor.mainSkill.skillFlags.selfCast then
	local effect = m_floor(75 * (1 + modDB:Sum("INC", nil, "BuffEffectOnSelf") / 100))
	modDB:NewMod("Speed", "MORE", effect, "Fanaticism", ModFlag.Cast)
	modDB:NewMod("Cost", "INC", -effect, "Fanaticism", ModFlag.Cast)
	modDB:NewMod("AreaOfEffect", "INC", effect, "Fanaticism", ModFlag.Cast)
end

QuickStick123 avatar Sep 26 '22 01:09 QuickStick123

@QuickStick123 This is just a tooltip text change so i don't think it matters.

Paliak avatar Sep 26 '22 07:09 Paliak

Thank you for your kind words.😊

On Mon, Sep 26, 2022, 3:31 AM Paliak @.***> wrote:

@QuickStick123 https://github.com/QuickStick123 This is just a tooltip text change so i don't think it matters.

— Reply to this email directly, view it on GitHub https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/5103#issuecomment-1257601076, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFGMGDBSLO55Y3DOAQV7FTWAFGLVANCNFSM6AAAAAAQTD6DJU . You are receiving this because you authored the thread.Message ID: @.***>

MeDott29 avatar Oct 07 '22 13:10 MeDott29