Incorrect Interactions between Eldritch Battery and Mana-based Conditionals

[ninjaprawn]

Check version

• [X] I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• [X] I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

While using Eldritch Battery and any mana-based conditionals, either POB should assume there is no realistic way to trigger the mana conditionals or provide a warning to the user that it is unlikely that they would be able to trigger the conditionals.

Note a case where POB should be calculating mana consumption is when using an aura with Divine Blessing Support, and the following conditions are met:

• Eldritch Battery is active
• The user has unreserved mana
• The aura cost is greater than the amount of energy shield, but lower than the amount of energy shield + the amount of mana (aka the user can still cast the ability)

In this scenario, an Inspiration Charge would be generated, and Arcane Surge Support would also trigger (assuming the amount of mana consumed meets the gems requirement).

What is the actual behaviour/value?

While using Eldritch Battery, POB assumes that any mana-based conditionals are still valid and able to be triggered with the build's setup. Such conditionals include, but not limited to:

• Inspiration Support
• Arcane Surge Support

When using the above supports with Eldritch Battery, POB will calculate the DPS increase as though the user has spent enough mana to trigger them.

How to reproduce the issue

1. Allocate Eldritch Battery on the passive tree on any class/ascendency
2. Add the following line to the custom modifiers: +200 to maximum energy shield
3. Add two of any 50% auras to have 0 unreserved mana (e.g. Determination and Grace)
4. Add Lightning Conduit to a new skill group, and ensure it is selected as the main skill in the side panel to observe the Average Hit.
5. Add Arcane Surge Support to Lightning Conduit, and observe the Average Hit Increase.
6. Replace Arcane Surge Support with Inspiration Support, and observe the Average Hit is higher than the number observed in Step 4

Character build code

https://pobb.in/hSHLJmEMRqeA

Screenshots

No response