PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Automatically apply Energy Blade buff

Open QuickStick123 opened this issue 3 years ago • 3 comments

Fixes https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/4100#issuecomment-1233635861

Description of the problem being solved:

Energy blade due to overwriting the weapon creates problems due to circular dependencies. The previous solution resolved this by a config option. This checks if energy blade is present in a first pass recalculates everything with the AffectedByEnergyBlade flag if it is.

Steps taken to verify a working solution:

  • Enabling/Disabling the gem now enables/disables energy blade and correctly enables/disables stats on weapon.

Link to a build that showcases this PR:

https://poe.ninja/pob/FHZ

QuickStick123 avatar Sep 01 '22 06:09 QuickStick123

Is it be possible to use overrides var for the flag var in initEnv ? I think that would be more elegant.

Paliak avatar Sep 02 '22 07:09 Paliak

Does this mean it will be implemented in the next release?

livejamie avatar Sep 07 '22 07:09 livejamie

Does this mean it will be implemented in the next release?

Once this PR is reviewed, it'll be merged and then will make it into the next release, yes

Wires77 avatar Sep 07 '22 12:09 Wires77

Hello @QuickStick123 , when I import current characters from poe.ninja using Energy Blade it's showing the incorrect ES still. The problem seems to be because POB is confused by the main weapon slot being "empty."

Once I add any weapon, it seems to work as expected.

Example character: https://poe.ninja/challenge/builds/char/SpiritKinay/SpiritSanctum

livejamie avatar Jan 18 '23 08:01 livejamie

I notified the poe.ninja person about this a few weeks ago. It is caused by us treating energy blade specially. It works correctly if you import the character but if you copy paste the item (energy blade) which I think poe.ninja functionally does it doesn't work.

QuickStick123 avatar Jan 18 '23 08:01 QuickStick123