Fix: Icenova interaction with GreaterSpellEcho and AwakenedSpellecho on Casting on Frostbolt
Fixes #2292 .
Description of the problem being solved:
The problem is that Ice Nova doesn't repeat when using Spell Echo( or Greater/ Awakaned version) but instead "expands". Thus conditionals for repeated actions shouldnÄt apply here for Ice Nova.
Therefore the solution should reverse the buffs if CastOnFrostBolt is invoked. The only 2 spells which can invoke this are Ice Nova and Vortex. But the latter is an instant spell thus not supported by Spell Echo.
Steps taken to verify a working solution:
-
I've looked into all combinations from Awakened Spell Echo and Greater Spell Echo casted on FrostBolt.
-
Double Damage calculation was checked with the Skill Hit Damage table under Calcs to see if any positive or negative double Damage Source is beeing applied. The same goes for the increased Aoe

Link to a build that showcases this PR:
https://pastebin.com/UEM2NN9c
Before screenshot:
After screenshot:
same issues as your other skill PRs, need to edit the .txt file as well otherwise the changes will get overridden when the skills are exported
added now. learned this for the future now
This should probably also apply to the divergent spell echo
["support_spell_echo_final_repeat_damage_+%_final"] = { mod("Damage", "MORE", nil), --Average out over the casts div = 3 }
Good catch. I've added the frostbolt condition.

