PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Published 20 hours ago • verified publisher icon PathOfBuildingCommunity

Do not hide config options that are configured without source

Open deathbeam opened this issue 1 year ago • 4 comments

Instead highlight them in red to let user know its an error.

Closes https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/4407 Closes https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/4468 Closes https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/1945 Closes #4841

Link to a build that showcases this PR:

https://pobb.in/jJf-KmAMp90k

Screenshot

image

deathbeam avatar Aug 09 '22 12:08 deathbeam

I will get rid of the merge commit soon-ish, fresh dev env on other pc :d

deathbeam avatar Aug 09 '22 12:08 deathbeam

Added right-click reset and also tooltip detail:

VirtualBoxVM_bXCZJBIKFU

deathbeam avatar Aug 09 '22 13:08 deathbeam

Removed the right click resetting again as it was buggy with number inputs and I couldnt figure out how to fix it

deathbeam avatar Aug 09 '22 14:08 deathbeam

Fixes https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/4841.

QuickStick123 avatar Aug 16 '22 05:08 QuickStick123