PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Fix dps comparison not working correctly when using the saviour and using overrides

Open Paliak opened this issue 3 years ago • 0 comments

Fixes #4631 .

Description of the problem being solved:

Overrides were not propagating through the call to initEnv in copyActiveSkill which was causing issues with dps comparison. Fixing that issues caused dps comparison to only work correctly when an odd number of skills was selected for full fps due to flask toggles being applied multiple times to a single env instance because of caching in calcs.calcFullDPS. Toggling flasks only when a cached env is not present seems to resolve the issue.

Steps taken to verify a working solution:

  • Tested with and without The Saviour and got expected behavior

Paliak avatar Jul 23 '22 07:07 Paliak