PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Added checkbox to quickly toggle flasks in the calcs tab

Open AlphSpirit opened this issue 2 years ago • 2 comments

Description of the problem being solved:

I wanted a quick and easy way to see what my final DPS would be like without flasks up, in a scenario like Uber bosses where my build doesn't generate any flask charges during the fight. But only without flasks and not everything else the Calculation Mode removes. So I added a little checkbox just below it to quickly toggle flasks on or off.

Since this is the first time I am contributing to PoB I am very open to criticism and feedback.

Link to a build that showcases this PR:

https://pastebin.com/14gXSciK

Before screenshot:

image

After screenshot:

image

AlphSpirit avatar Jul 14 '22 15:07 AlphSpirit

I like the idea, one problem I noticed while testing though: if you uncheck the "Flasks Active" option, save, and reload a build — the DPS shown under Calcs continues to calculate as if flasks were disabled, but the checkbox itself goes back to being enabled. Unless you toggle the checkbox off and on again it stays stuck in this state.

It also might make more sense for this to be an option listed under Calculation Mode instead of a separate checkbox, I'm not really sure how much utility there is in being able to combine all 4 different calculation modes with the checkbox (as opposed to just having some sort of "Effective DPS + Flasks Disabled" mode).

Lothrik avatar Jul 18 '22 04:07 Lothrik

I actually started by adding a 5th calculation mode like you said, but it was a bit annoying to switch it back and forth if you are looking at multiple things with and without flasks. It does fit a lot better in the UI though like you said, and I don't consider myself an average user, so I'd love to get opinions on this.

For the save thing, its probably due to the fact I put my flag to true by default but somehow it saves its state in the build as well. Will have a look into that.

AlphSpirit avatar Jul 18 '22 12:07 AlphSpirit