PathOfBuilding-PoE2 icon indicating copy to clipboard operation
PathOfBuilding-PoE2 copied to clipboard

Guess main socket group based on dps + Full import button

Open Musholic opened this issue 2 months ago • 0 comments

Description of the problem being solved:

This PR allows to have a one-button full import while allowing to better guess which socket group is the main one based on DPS calculations of all groups. It also includes the main skill in Full DPS.

Note that if we cannot import with only one button, it causes an issue where the variable mainSkillEmpty = #self.build.skillsTab.socketGroupList == 0 is false because there is a skill coming from the tree ("Called shots" in my case).

This is also useful for the automatic test I'm preparing to have more relevant tests (having a skill correctly included for the full dps stats) (https://github.com/Musholic/PathOfBuilding-PoE2/pull/11).

  • [ ] I tested the performance on a simple character import (it was very fast), however it needs to be tested on more complex characters before we merge this PR

Steps taken to verify a working solution:

  • Tested with my lvl 35 character

Before screenshot:

image

After screenshot:

image

Musholic avatar Sep 16 '25 16:09 Musholic