Patrick St-Louis

Results 107 comments of Patrick St-Louis

I would like to support the Digital Credentials API in the [PyDentity Wallet from the Open Wallet Foundation](https://github.com/openwallet-foundation-labs/PyDentity-Wallet). We currently support CHAPI exchanges and look forward extending other credential exchanges/integrations...

@pruneau628 I've addressed this through #1679. Are you ok if we close this issue?

@dbluhm that sounds good to me, thanks!

I will have a look, no additional tests were added and no changes are expected if the flag is not added. Maybe there's a bad condition check somewhere.

@dbluhm @jamshale I think I found the error, copy paste mistake. I was registering the ledger as a package and not a plugin. Lets see how the test go now

Tests passed, updating the branch

@dbluhm @jamshale branch updated, all tests are passing. Let me know if you need anything else!

As @TimoGlastra pointed out, since generating the SCID requires JCS, using JWS would actually add complexity to the overall spec, negating the main purpose behind this suggestion. The simplicity of...

> Implementers of did:tdw would not have to read up on the specification at all and just use a library that supports it. I find the argument of going with...

Your did document is odd, you set the type to `Ed25519VerificationKey2018` but display the key as a json web key. `Ed25519VerificationKey2018` requires a `publicKeyBase58` representation of the public key. Change...