docs.particular.net icon indicating copy to clipboard operation
docs.particular.net copied to clipboard

Feedback: 'Integrating with Azure Application Insights'

Open bbrandt opened this issue 1 year ago • 6 comments

Feedback for 'Integrating with Azure Application Insights' https://docs.particular.net/servicecontrol/app-insights-integration

Location in GitHub: https://github.com/Particular/docs.particular.net/blob/master/servicecontrol/app-insights-integration.md

This statement mentions retries, processing time, and critical time:

It is possible to gather performance metrics like Processing Time and Critical Time as well as data on the number of immediate and delayed retries.

But this links to a sample that does not seem to publish retries, processing time, and critical time:

For more details, see this sample.

List of metrics from the sample:

Metrics: nservicebus.messaging.successes nservicebus.messaging.failures nservicebus.messaging.fetches

bbrandt avatar Feb 08 '24 04:02 bbrandt

Thanks Ben,

We're consolidating some samples in anticipation of the release of NServiceBus 9 and it looks like the task force got a little over-zealous and redirected the old sample that talked about all those things to the newer OpenTelemetry sample that doesn't quite do all those things. We're going to look at bringing those concepts over to the OTel sample to have a best of both worlds. Stay tuned.

DavidBoike avatar Feb 08 '24 16:02 DavidBoike

@bbrandt FYI we are working on the expanded sample over here if you are curious

https://github.com/Particular/docs.particular.net/pull/6452

andreasohlund avatar Feb 19 '24 15:02 andreasohlund

@SzymonPobiega @lailabougria, did we add the mentioned metric natively in v9.1?

andreasohlund avatar Aug 19 '24 11:08 andreasohlund

We did: https://docs.particular.net/nservicebus/operations/opentelemetry#meters-emitted-meters

lailabougria avatar Aug 20 '24 07:08 lailabougria

@lailabougria so we can go through the v9 samples and remove the shims right?

eg. https://github.com/Particular/docs.particular.net/tree/master/samples/open-telemetry/application-insights/Core_9/Endpoint/MetricsShim

andreasohlund avatar Aug 20 '24 07:08 andreasohlund

Yes, we are doing it as part of https://github.com/Particular/docs.particular.net/pull/6777

SzymonPobiega avatar Aug 20 '24 08:08 SzymonPobiega