NServiceBus.Persistence.Sql
NServiceBus.Persistence.Sql copied to clipboard
ScriptBuilder has code for DateTime/DateTimeOffset as correlation property, but that's unsupported by Core
The ScriptBuilder project contains code paths to deal with CorrelationPropertyType values of DateTime and DateTimeOffset (and these are also documented here, via an include here) even though NServiceBus limits correlation property types to string, Guid, long, ulong, int, uint, short, ushort, as a runtime check and raised to a compile-level check with a Roslyn analyzer.
That is, in a word, weird. Especially since the runtime type checks have been around since NServiceBus 6.0.0, and SQL Persistence did not exist prior to NServiceBus 6.
This should be investigated, unusable code paths should be removed to simplify things, and documentation should be updated to match.