GitHubReleaseNotes icon indicating copy to clipboard operation
GitHubReleaseNotes copied to clipboard

Exclude PullRequests from the release notes

Open timbussmann opened this issue 8 years ago • 4 comments

In the core repo, we're experimenting with adding milestones to every PR to help interested users to find out which release contains these changes (without digging in the git commits for too long). This becomes very cumbersome as soon as we have an associated issue for a PR which also receives the milestone (because of the release notes) as we have to manually ensure that there are no "duplicates" (and the issue can have a different title as the associated PR) or that only PRs without associated issues have the milestones assigned, which is easy to miss. It seems like one option would be to exclude PRs from the release notes altogether and force the creation of an issue if that PR should be mentioned in the release notes.

Thoughts?

cc @Particular/nservicebus-maintainers

timbussmann avatar Jan 18 '17 16:01 timbussmann

Since this would affect other repos as well we need to ping more maintainers.

Another option would be to not include the PR if the PR mentions an issue with the same milestone (funky logic though)

danielmarbach avatar Jan 18 '17 20:01 danielmarbach

Another option would be to not include the PR if the PR mentions an issue with the same milestone (funky logic though)

yeah that idea came up in yesterdays discussion too but I think that's just going to far.

timbussmann avatar Jan 19 '17 07:01 timbussmann

Well, there can be a config switch so that the current behavior is default but you can opt in to filter out the PRs.

SzymonPobiega avatar Jan 25 '17 08:01 SzymonPobiega

Well, there can be a config switch so that the current behavior is default but you can opt in to filter out the PRs.

good enough imho

timbussmann avatar Jan 25 '17 11:01 timbussmann